Skip to content

Fix load_module deprecation warnings for Python >= 3.10. - #432

Merged
malthe merged 1 commit into
malthe:masterfrom
fschulze:load_module-deprecation
Dec 11, 2024
Merged

malthe merged 1 commit into
malthe:masterfrom
fschulze:load_module-deprecation

Conversation

@fschulze

Copy link
Copy Markdown
Contributor

The lint and mypy errors are also on master. I guess newer mypy added some errors and the Python versions changed because of latest Python release since last run 6 months ago.

@malthe

malthe commented Dec 11, 2024

Copy link
Copy Markdown
Owner

I don't understand why linting errors mean we have to change this code? Did something not work before?

@fschulze

Copy link
Copy Markdown
Contributor Author

This change is only about the deprecation warning. I only meant that current tox run isn't passing, because of unrelated changes outside of Chameleon and this PR.

@malthe

malthe commented Dec 11, 2024

Copy link
Copy Markdown
Owner

OK, I somehow thought all of this had been revamped in #396.

@fschulze

Copy link
Copy Markdown
Contributor Author

That was how to determine the module name etc. This is about changes in the importlib and zipimport modules in Python 3.10. It looks like the removal of those methods was planned for 3.12 but postponed.

@malthe
malthe merged commit 9ea8bac into malthe:master Dec 11, 2024
@malthe

malthe commented Dec 11, 2024 •

Copy link
Copy Markdown
Owner

Not sure why the testing workflow was disabled. Yes, the repository has had no activity for 60 days, but now it has thanks to your pull request.

There seems to be some minor problems: https://github.com/malthe/chameleon/actions/runs/12280815714/job/34268167089.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants