Skip to content

np.float_ -> np.float64 - #218

Merged
bmcfee merged 1 commit into
marl:masterfrom
giovana-morais:fix_numpy_float
Dec 6, 2024
Merged

bmcfee merged 1 commit into
marl:masterfrom
giovana-morais:fix_numpy_float

Conversation

@giovana-morais

Copy link
Copy Markdown
Contributor

Hi all!
I tried to use mirdata with Python 3.10+ and jams was throwing an error regarding np.float_, so this PR changes that whenever it is necessary.

After doing the changes, I installed the library locally and had no problem with mirdata anymore.
I was not able to run the tests though. It seems that nose is unmaintained and not supported for Python 3.10+, so I'm not sure how to proceed here.

@bmcfee
bmcfee merged commit 1fcee0a into marl:master Dec 6, 2024
@bmcfee

bmcfee commented Dec 6, 2024

Copy link
Copy Markdown
Member

Merging this since it's an obvious fix; will need to put some more work into modernizing CI to handle other stuff though

@giovana-morais
giovana-morais deleted the fix_numpy_float branch February 19, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants