Implement P2210R2 Superior String Splitting by miscco · Pull Request #2042 · microsoft/STL

Michael Schellenberger Costa (miscco) · 2021-07-06T16:02:11Z

This implements the first part of P2210R2 renaming split_view to lazy_split_view

Works towards #1980.

Fixes microsoft#1980

Co-authored-by: Adam Bucior <35536269+AdamBucior@users.noreply.github.com>

Stephan T. Lavavej (StephanTLavavej) · 2021-07-21T21:47:44Z

Michael Schellenberger Costa (@miscco) - Are you still working on resolving timsong-cpp's comments, or were they resolved in the recent commits? Just wondering whether this should move to Initial Review again. 😺

Michael Schellenberger Costa (miscco) · 2021-07-22T15:12:12Z

Michael Schellenberger Costa (@miscco) - Are you still working on resolving timsong-cpp's comments, or were they resolved in the recent commits? Just wondering whether this should move to Initial Review again. 😺

Actually this is something that I would want to get Casey Carter (@CaseyCarter)'s opinion on. As far as I remember his analysis was that we do not need to do anything related to P2281 and if we change something here I would want to be sure we change it consistently everywhere

Co-authored-by: Casey Carter <cartec69@gmail.com>

Michael Schellenberger Costa (miscco) · 2021-08-25T07:47:56Z

Casey Carter (@CaseyCarter) I would also suggest to move this to a follow up. As far as I can tell there are two things we need to do

Improve the perfect forwarding for the adaptors
Iplement decay-copy for split_view and lazy_split_view

Given that those are non trivial changes (and I currently do not have that much capacity for delicate tasks) I feel it is better to extract them into a follow up.

Stephan T. Lavavej (StephanTLavavej)

Thanks! I'll push changes to address my feedback (they were all localized).

Michael Schellenberger Costa (miscco) · 2021-09-01T07:14:53Z

Thanks a lot for the review and the fixes 😸

Stephan T. Lavavej (StephanTLavavej) · 2021-09-02T00:28:13Z

I'm mirroring this to an MSVC-internal PR - please notify me if any further changes are pushed.

Stephan T. Lavavej (StephanTLavavej) · 2021-09-02T04:35:52Z

"Thanks", "For", "Implementing", "This", "C++20", "Defect", "Report" 😸

Michael Schellenberger Costa (miscco) requested a review from a team as a code owner July 6, 2021 16:02

Michael Schellenberger Costa (miscco) force-pushed the P2210-superior-string-splitting branch from 57ef4a1 to f0ac30c Compare July 6, 2021 19:22

Stephan T. Lavavej (StephanTLavavej) added cxx20 C++20 feature defect report Applied retroactively ranges C++20/23 ranges labels Jul 6, 2021

Stephan T. Lavavej (StephanTLavavej) requested changes Jul 6, 2021

View reviewed changes

Comment thread stl/inc/ranges Outdated

Implement first part of P2210R2 Superior String Splitting

1fae222

Michael Schellenberger Costa (miscco) force-pushed the P2210-superior-string-splitting branch from f0ac30c to 1fae222 Compare July 7, 2021 06:25

Stephan T. Lavavej (StephanTLavavej) assigned Casey Carter (CaseyCarter) Jul 7, 2021

Michael Schellenberger Costa (miscco) added 4 commits July 18, 2021 11:31

Implement ranges::split_view

6929561

Fixes microsoft#1980

Hoist ranges::search into xutility

717156f

Explicitly default all SMF for subrange

f071283

constexpr ...

25680c3

Michael Schellenberger Costa (miscco) changed the title ~~Implement first part of P2210R2 Superior String Splitting~~ Implement P2210R2 Superior String Splitting Jul 19, 2021

Adam Bucior (AdamBucior) reviewed Jul 19, 2021

View reviewed changes

Comment thread tests/std/tests/P0896R4_ranges_range_machinery/test.cpp

Comment thread tests/std/tests/P0896R4_views_split/test.cpp Outdated

Address review comments

fd802d0

Co-authored-by: Adam Bucior <35536269+AdamBucior@users.noreply.github.com>

Adam Bucior (AdamBucior) approved these changes Jul 19, 2021

View reviewed changes

Michael Schellenberger Costa (miscco) commented Jul 19, 2021

View reviewed changes

Comment thread stl/inc/ranges

timsong-cpp suggested changes Jul 20, 2021

View reviewed changes

Comment thread stl/inc/ranges

Comment thread stl/inc/ranges

Merge branch 'main' into P2210-superior-string-splitting

f9f9fc1

Adam Bucior (AdamBucior) reviewed Jul 20, 2021

View reviewed changes

Comment thread stl/inc/ranges

Michael Schellenberger Costa (miscco) added 2 commits July 20, 2021 18:28

Fix merge conflict

052717c

All hail the formatting gods

7e9e444

Michael Schellenberger Costa (miscco) force-pushed the P2210-superior-string-splitting branch from d3101f4 to 7e9e444 Compare July 20, 2021 16:35

Casey Carter (CaseyCarter) mentioned this pull request Aug 4, 2021

P2281R1 Clarifying Range Adaptor Objects #1983

Closed

Casey Carter (CaseyCarter) suggested changes Aug 4, 2021

View reviewed changes

Michael Schellenberger Costa (miscco) and others added 2 commits August 4, 2021 08:28

Apply suggestions from code review

b2a50a9

Co-authored-by: Casey Carter <cartec69@gmail.com>

Merge branch 'main' into P2210-superior-string-splitting

91c543e

Michael Schellenberger Costa (miscco) added 2 commits August 11, 2021 11:52

Enable caching of the next subrange for views::split

6c7af9d

Address review comments

0c0af4c

Adam Bucior (AdamBucior) mentioned this pull request Aug 12, 2021

Optimize _Non_propagating_cache #2118

Merged

Casey Carter (CaseyCarter) linked an issue Aug 19, 2021 that may be closed by this pull request

P2210R2 Superior String Splitting #1980

Closed

Casey Carter (CaseyCarter) approved these changes Aug 24, 2021

View reviewed changes

Comment thread stl/inc/ranges

Comment thread stl/inc/ranges

Comment thread tests/std/tests/P0896R4_views_split/test.cpp Outdated

Comment thread tests/std/tests/P0896R4_views_split/test.cpp Outdated

Casey's last nitpicky comments

6bee70f

Merge branch 'main' into P2210-superior-string-splitting

275dbc0

This comment has been minimized.

Sign in to view

Casey Carter (CaseyCarter) removed their assignment Aug 31, 2021

Stephan T. Lavavej (StephanTLavavej) self-assigned this Aug 31, 2021

Stephan T. Lavavej (StephanTLavavej) added 10 commits August 31, 2021 12:50

Repair clang-format suppression.

f2f5c6f

Add space in comment.

50de9de

split_view's ctor should take forward_range.

02d2acd

Add strengthened comment.

d438cfd

P2367R0/N4892 changed single_view{meow} to views::single(meow).

e773d40

Mark base() overloads as _NODISCARD.

fdb30b5

split_view::base() requires copyable<V>.

71cbc10

West const.

ad5863b

Verify from_chars success.

148fe0a

Newline between non-chained if (constexpr) statements.

9cb5ac6

Stephan T. Lavavej (StephanTLavavej) reviewed Sep 1, 2021

View reviewed changes

Stephan T. Lavavej (StephanTLavavej) approved these changes Sep 1, 2021

View reviewed changes

Stephan T. Lavavej (StephanTLavavej) removed their assignment Sep 1, 2021

Stephan T. Lavavej (StephanTLavavej) self-assigned this Sep 2, 2021

Stephan T. Lavavej (StephanTLavavej) merged commit 21961bb into microsoft:main Sep 2, 2021

Michael Schellenberger Costa (miscco) deleted the P2210-superior-string-splitting branch September 2, 2021 05:11

Conversation

Michael Schellenberger Costa (miscco) commented Jul 6, 2021 • edited by StephanTLavavej Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Stephan T. Lavavej (StephanTLavavej) commented Jul 21, 2021

Uh oh!

Michael Schellenberger Costa (miscco) commented Jul 22, 2021 • edited by StephanTLavavej Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Michael Schellenberger Costa (miscco) commented Aug 25, 2021

Uh oh!

This comment has been minimized.

Stephan T. Lavavej (StephanTLavavej) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Michael Schellenberger Costa (miscco) commented Sep 1, 2021

Uh oh!

Stephan T. Lavavej (StephanTLavavej) commented Sep 2, 2021

Uh oh!

Stephan T. Lavavej (StephanTLavavej) commented Sep 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Michael Schellenberger Costa (miscco) commented Jul 6, 2021 •

edited by StephanTLavavej

Loading

Michael Schellenberger Costa (miscco) commented Jul 22, 2021 •

edited by StephanTLavavej

Loading