move_only_function: more concise Python script - #2429
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoJan 20, 2022
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
Conversation
TIL what is string interpolation
Alex Guteniev (AlexGuteniev)
changed the title
move_only_function: more concise Python script
Stephan T. Lavavej (StephanTLavavej)
added
the
enhancement
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Dec 17, 2021
This comment has been minimized.
This comment has been minimized.
Igor Zhukov (fsb4000)
approved these changes
Dec 18, 2021
Curtis J Bezault (cbezault)
suggested changes
Jan 14, 2022
Alex Guteniev (AlexGuteniev)
requested a review
from Curtis J Bezault (cbezault)
January 14, 2022 22:14
Curtis J Bezault (cbezault)
approved these changes
Jan 14, 2022
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jan 14, 2022
Member
|
Verified that the script's output still matches the product code, again. |
Casey Carter (CaseyCarter)
approved these changes
Jan 19, 2022
|
|
||
|
|
||
| print(cvref_permutations("", "false", "is_invocable_r_v") + "\n" \ | ||
| + "#ifdef __cpp_noexcept_function_type" + "\n" \ |
Contributor
There was a problem hiding this comment.
"..." + "..." is a bit silly when we can simply concatenate the two strings. Not worth resetting testing, however.
Contributor
Author
There was a problem hiding this comment.
I preferred this way for consistency with other occurrences where "\n" is a separate string
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for improving code clarity of this script! 🐍 👓 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TIL what is string interpolation