Fix begin/end for valarray crashing on empty instance - #2435
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits intoJan 20, 2022
Merged
Conversation
|
|
Michael Schellenberger Costa (miscco)
approved these changes
Dec 19, 2021
Casey Carter (CaseyCarter)
approved these changes
Dec 19, 2021
Casey Carter (CaseyCarter)
left a comment
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
I'm going to apply my suggestions which clean up pre-existing weirdness in <valarray>.
There's no reason to make friend declarations private.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jan 19, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for fixing this bug - and congratulations on your first microsoft/STL commit! 🎉 😻 🚀 This will ship as part of VS 2022 17.2 Preview 2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue also causes range-based for loops to break for empty valarrays.
I also added regression tests, which I hope are fine.
If there's anything wrong just tell me and I'll happily adjust!