implement LWG-3471: polymorphic_allocator::allocate does not satisfy Cpp17Allocator requirements - #2567
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits intoFeb 18, 2022
Conversation
Co-authored-by: A. Jiang <de34@live.cn>
Contributor
|
The original wording is incorrect (and the The intended implementation (taking advantage of [intro.object]/13) is return ::operator new(_Bytes, _Ptr); |
Co-authored-by: timsong-cpp <rs2740@gmail.com>
Casey Carter (CaseyCarter)
approved these changes
Feb 14, 2022
Casey Carter (CaseyCarter)
left a comment
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
I can't imagine how we would test for this, so I won't ask for test coverage.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Feb 15, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. (I'll handle verifying that this works with the recent LLVM update.) |
Stephan T. Lavavej (StephanTLavavej)
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Feb 17, 2022
Member
|
Thanks for implementing another LWG issue resolution! ✅ 💯 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2550
I saw that the changes were in "Previous resolution [SUPERSEDED]" but as far as I understand the new resolution is needed because of changing the wording and the proposed implementation stays the same.
std::launderis in<new><xmemory>includes<new><xpolymorphic_allocator.h>includes<xmemory>