Untag dispatch <random> - #2693
Merged
Stephan T. Lavavej (StephanTLavavej) merged 10 commits intoMay 5, 2022
Merged
Stephan T. Lavavej (StephanTLavavej) merged 10 commits into
Stephan T. Lavavej (StephanTLavavej) merged 10 commits into
Conversation
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@gmail.com>
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@gmail.com>
Stephan T. Lavavej (StephanTLavavej)
added
throughput
Stephan T. Lavavej (StephanTLavavej)
approved these changes
May 4, 2022
nicole mazzuca (strega-nil-ms)
suggested changes
May 4, 2022
nicole mazzuca (strega-nil-ms)
left a comment
nicole mazzuca (strega-nil-ms)
left a comment
Contributor
There was a problem hiding this comment.
_Seed does not need to be a template; additionally, an existing narrowing conversion stops working with these changes.
This comment was marked as resolved.
This comment was marked as resolved.
this is more in line with the standard, and allows us to remove `_Seed`
Contributor
|
I've pushed changes that fix my comments |
nicole mazzuca (strega-nil-ms)
approved these changes
May 4, 2022
nicole mazzuca (strega-nil-ms)
requested a review
from Stephan T. Lavavej (StephanTLavavej)
May 4, 2022 18:54
Stephan T. Lavavej (StephanTLavavej)
approved these changes
May 4, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for delving into this ancient header and solving this puzzle! 😹 🧩 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #189