Speculatively implement LWG-3234: Sufficient Additional Special Math Overloads - #2703
Merged
Stephan T. Lavavej (StephanTLavavej) merged 9 commits intoMay 5, 2022
Merged
Stephan T. Lavavej (StephanTLavavej) merged 9 commits into
Stephan T. Lavavej (StephanTLavavej) merged 9 commits into
Conversation
LWG-3234 is resolved by WG21-P1467, which has been approved. Also strengthen exception specifications of math special functions and update comments to reference N4910. float/long double overloads are not added at this moment (LWG-3693).
Casey Carter (CaseyCarter)
suggested changes
May 4, 2022
Casey Carter (CaseyCarter)
left a comment
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
This is amazing! Thank you.
Casey Carter (CaseyCarter)
approved these changes
May 4, 2022
Contributor
|
Stephan T. Lavavej (StephanTLavavej)
approved these changes
May 5, 2022
Casey Carter (CaseyCarter)
approved these changes
May 5, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing these special overloads! 😻 ✨ 🧮 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #910.
IIUC LWG-3234 will be resolved by the recently approved paper WG21-P1467, so perhaps it is not speculative to implement the resolution.
No separated
float/long doubleoverloads are added according to #1335. I've filed LWG-3693 for this. I'm not sure whether non-templatedoubleoverloads can be removed.I'm also strengthening exception specifications of math special functions as the underlying operations only call
noexceptfunctions, and updating comments to reference WG21-N4910.