Untag dispatch get for pair - #2756
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoJun 12, 2022
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
Conversation
Michael Schellenberger Costa (miscco)
approved these changes
Jun 3, 2022
Alex Guteniev (AlexGuteniev)
approved these changes
Jun 3, 2022
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 3, 2022
Member
|
Nice catch and great cleanup! 😻 |
Casey Carter (CaseyCarter)
approved these changes
Jun 6, 2022
Casey Carter (CaseyCarter)
left a comment
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
I've asked for way too many additional changes; I'll make them myself.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 6, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks again for finding and improving the throughput and debug codegen of these functions! 😺 🎉 🚀 |
Igor Zhukov (fsb4000)
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: Casey Carter <Casey@Carter.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #189.
Error message is emitted by
tuple_element_tif_Idx >= 2, so it is not needed to be repeated inget.