<__msvc_int128.hpp>: Move UDLs to test code - #3252
Merged
Stephan T. Lavavej (StephanTLavavej) merged 4 commits intoDec 6, 2022
Merged
Stephan T. Lavavej (StephanTLavavej) merged 4 commits into
Stephan T. Lavavej (StephanTLavavej) merged 4 commits into
Conversation
nicole mazzuca (strega-nil-ms)
approved these changes
Dec 1, 2022
nicole mazzuca (strega-nil-ms)
left a comment
nicole mazzuca (strega-nil-ms)
left a comment
Contributor
There was a problem hiding this comment.
Thank you for moving these over!
Contributor
Author
|
I (again) misused |
Casey Carter (CaseyCarter)
approved these changes
Dec 1, 2022
Casey Carter (CaseyCarter)
left a comment
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
Some minor nits for which I'll push changes.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Dec 5, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks again for this throughput improvement! 😻 🚀 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3240.
It was my decision to add these UDLs to product code in order to provide a solution for DevCom-879048. But it turns out that this is non-goal, and thus it was my fault to do so.
Per discussions in #3240, these UDLs should be moved into the test code. I decided to make these identifiers non-_Ugly despite that it may be OK not to do so.