<optional>: Fix exception specification for optional's transform-construction - #3668
Merged
Stephan T. Lavavej (StephanTLavavej) merged 9 commits intoApr 28, 2023
Conversation
making the exception specification consistent with `expected` Co-authored-by: S. B. Tam <cpplearner@outlook.com>
nicole mazzuca (strega-nil-ms)
approved these changes
Apr 24, 2023
nicole mazzuca (strega-nil-ms)
left a comment
nicole mazzuca (strega-nil-ms)
left a comment
Contributor
There was a problem hiding this comment.
Oh wow, we totally missed that. Thanks for the fix, A. Jiang (@frederick-vs-ja)!
S. B. Tam (cpplearner)
approved these changes
Apr 24, 2023
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Apr 24, 2023
Member
|
Thanks! FYI nicole mazzuca (@strega-nil-ms) I pushed an expansion of test coverage after you approved. |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for fixing this bug in new code! 🐞 🛠️ 😻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3667.