Silence 3 static analysis warnings - #3743
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoMay 31, 2023
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
Conversation
Stephan T. Lavavej (StephanTLavavej)
added
the
enhancement
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
May 31, 2023 20:10
Member
Author
|
I have speculatively mirrored this to MSVC-PR-475347 to fast-track it. |
Casey Carter (CaseyCarter)
suggested changes
May 31, 2023
Co-authored-by: Casey Carter <Casey@Carter.net>
Stephan T. Lavavej (StephanTLavavej)
requested a review
from Casey Carter (CaseyCarter)
May 31, 2023 20:54
Casey Carter (CaseyCarter)
approved these changes
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #3734.
I've filed a tracking bug VSO-1828677 "False positive warning C26450 (arithmetic overflow) in charconv and memory_resource" for the static analysis team to investigate, and Dmitry Kobets (@dmitrykobets-msft) has added fully reduced repros there. Our code is correct, so we need to silence this warning until the compiler is fixed.
For
locale::_Ptr, attempting to initialize it will break the STL catastrophically. I'm permanently suppressing the warning, with an explanation of the squirrelly 🐿️ behavior involved. In theory, this is not ABI-sensitive sinceclassic_localeis isolated to the locale0.cpp TU, but iostreams is extremely complicated and fragile and I am not eager to mess with this logic at this time unless absolutely forced to.