Skip to content

Use a static CRT in debug builds - #41684

Merged
Blue (OneBlue) merged 1 commit into
masterfrom
user/oneblue/debug-crt
Sep 23, 2026
Merged

Blue (OneBlue) merged 1 commit into
masterfrom
user/oneblue/debug-crt

Conversation

@OneBlue

Copy link
Copy Markdown
Collaborator

Summary of the Pull Request

This change reverts #40890 for debug builds, otherwise a debug build fails to install on machines that don't have the debug CRT dll installed with a cryptic error message

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@OneBlue
Blue (OneBlue) requested a review from a team as a code owner September 23, 2026 18:33
Copilot AI lite review requested due to automatic review settings September 23, 2026 18:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues remain.

Review effort: Lite
Findings: None

What changed in this PR

Updates CMake so Debug builds use the static CRT, avoiding a dependency on ucrtbased.dll, while preserving Release CRT behavior.

Changes:

  • Removes Debug dynamic CRT linker overrides.
  • Documents the Debug and Release CRT configurations.
File Description
CMakeLists.txt Adjusts configuration-specific MSVC CRT linkage.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@OneBlue
Blue (OneBlue) merged commit dba479c into master Sep 23, 2026
12 checks passed
@OneBlue
Blue (OneBlue) deleted the user/oneblue/debug-crt branch September 23, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants