Repository navigation
Impersonate the caller before making various filesystem operations - #41689
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
WSL2 compression detection still needs caller-token impersonation.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds caller/user-token impersonation around WSL service filesystem operations.
Changes:
- Impersonates callers during distribution path validation and directory creation.
- Uses the user token for rootfs compression checks.
| File | Summary |
|---|---|
src/windows/service/exe/LxssUserSession.cpp |
Adds impersonation for path validation and directory operations. |
src/windows/service/exe/LxssInstance.cpp |
Adds user-token impersonation for rootfs attribute checks; the corresponding WSL2 check remains unresolved. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ben Hillis (benhillis)
approved these changes
Sep 24, 2026
Ben Hillis (benhillis)
left a comment
Ben Hillis (benhillis)
left a comment
Member
There was a problem hiding this comment.
Seems ok to me, I guess we should impersonate even when checking the attributes as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change adds impersonation logic to various places where wslservice performs filesystem operations
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed