Skip to content

Exclude wslc.exe and wslcsession.exe from custom LSP providers - #41767

Merged
Blue (OneBlue) merged 2 commits into
masterfrom
user/oneblue/wslc-lsp
Oct 2, 2026
Merged

Blue (OneBlue) merged 2 commits into
masterfrom
user/oneblue/wslc-lsp

Conversation

@OneBlue

Copy link
Copy Markdown
Collaborator

Summary of the Pull Request

This change updates the installer logic to exclude wslc.exe and wslcsession.exe from custom LSP providers, like we already do with WSL executables.

PR Checklist

  • Closes: Link to issue wslc not work on my compute, most of its command report WSAEOPNOTSUPP #41758
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copilot AI balanced review requested due to automatic review settings October 2, 2026 00:23
@OneBlue
Blue (OneBlue) requested a review from a team as a code owner October 2, 2026 00:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The supported container.exe alias remains exposed to custom LSP providers.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Extends installer LSP exclusions to WSLC executables.

Changes:

  • Registers wslc.exe and wslcsession.exe as system applications.
  • Expands installer validation for these executables.
File Description
src/​windows/​wslinstall/​DllMain.cpp Extends LSP category registration.
test/​windows/​InstallerTests.cpp Verifies registration during installation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/windows/wslinstall/DllMain.cpp Outdated
Copilot AI balanced review requested due to automatic review settings October 2, 2026 00:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The installer and test changes consistently cover all WSLC executable paths.

Review effort: Balanced
Findings: None

Resolved since last review (1)

@OneBlue
Blue (OneBlue) merged commit 0e04306 into master Oct 2, 2026
12 checks passed
@OneBlue
Blue (OneBlue) deleted the user/oneblue/wslc-lsp branch October 2, 2026 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants