Repository navigation
Exclude wslc.exe and wslcsession.exe from custom LSP providers - #41767
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The supported container.exe alias remains exposed to custom LSP providers.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Extends installer LSP exclusions to WSLC executables.
Changes:
- Registers
wslc.exeandwslcsession.exeas system applications. - Expands installer validation for these executables.
| File | Description |
|---|---|
src/windows/wslinstall/DllMain.cpp |
Extends LSP category registration. |
test/windows/InstallerTests.cpp |
Verifies registration during installation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ben Hillis (benhillis)
approved these changes
Oct 2, 2026
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary of the Pull Request
This change updates the installer logic to exclude wslc.exe and wslcsession.exe from custom LSP providers, like we already do with WSL executables.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed