Skip to content

Revert "fix: confirm response based on promise (#263894)" - #264047

Merged
TylerLeonhardt merged 1 commit into
microsoft:mainfrom
rwoll:revert-tool-confirmation
Aug 29, 2025
Merged

TylerLeonhardt merged 1 commit into
microsoft:mainfrom
rwoll:revert-tool-confirmation

Conversation

@rwoll

@rwoll Ross Wollman (rwoll) commented Aug 29, 2025 •

Copy link
Copy Markdown
Member

This reverts commit 6f24cee.

It broke tool calling UI status: #264023.

I attempted to fix it (#264073) but still have some edge cases not working and will need more time to get to the bottom of it.

This reverts commit 6f24cee.

It broke tool calling: microsoft#264023.

I also need to re-asses how I missed this during testing.
@rwoll
Ross Wollman (rwoll) marked this pull request as draft August 29, 2025 18:09
@rwoll

Copy link
Copy Markdown
Member Author

Converting to draft while I investigate root cause/fix. If there's urgency to get this revert in, please ping me offline.

@rwoll

Copy link
Copy Markdown
Member Author

Superceded by linked PR with fix.

@rwoll

Ross Wollman (rwoll) commented Aug 29, 2025 •

Copy link
Copy Markdown
Member Author

There's still some issues in my attempt to fix (#264073), so re-opened this revert and will start fresh next week to get the functional behavior we desire.

@vs-code-engineering vs-code-engineering Bot added this to the August 2025 milestone Aug 29, 2025
@TylerLeonhardt
TylerLeonhardt merged commit b2fb4ac into microsoft:main Aug 29, 2025
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Oct 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants