Repository navigation
Commit typed cut time on blur instead of discarding it - #3133
Merged
Merged
Conversation
Clicking away from the start/end time inputs used to silently throw away what was typed. Now valid input is committed on blur, while Escape still cancels the edit. Also stop committing on every keystroke in frame count mode, where every prefix of a number is itself a valid frame number. Changelog: Cut time inputs now keep the typed time when clicking elsewhere (Escape still cancels), and frame count input no longer jumps while typing Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017QJfcnstoUXVtcR4FuTuTs Co-authored-by: Mikael Finstad <finstaden@gmail.com>
- Handle Escape in the input itself, so the skip-commit flag can't get stuck - Don't seek when committing on blur, it would override where the user clicked - Keep the text with error state if the blur commit fails - Keep the text when the whole window loses focus - Also clear manual text when switching to another segment - DRY paste handlers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017QJfcnstoUXVtcR4FuTuTs Co-authored-by: Mikael Finstad <finstaden@gmail.com>
- Keep (red) unparseable text on blur too, not only text that fails to apply - Toast the reason when a blur commit fails, since the input no longer has focus - Show red state when Enter fails - Simplify setTime and blur handler Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017QJfcnstoUXVtcR4FuTuTs Co-authored-by: Mikael Finstad <finstaden@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3126 / #3129.
123used to seek to 1, then 12, then 123.segId).setTime.parseAndSetCutTimerejectsNaNand is reused byhandleSubmit.Known edge case, not addressed: a modifier-drag on the timeline right after typing can overwrite the start that the blur just committed. Timeline's mousemove closure holds stale segments. Before this PR, the typed value was discarded anyway.
Verified: tsc, lint and tests pass. Not manually tested in the app yet.
🤖 Generated with Claude Code
https://claude.ai/code/session_017QJfcnstoUXVtcR4FuTuTs