Skip to content

fix: use PR author for commit-dist job condition - #1541

Merged
mikepenz merged 1 commit into
developfrom
fix/commit-dist-condition
Mar 27, 2026
Merged

mikepenz merged 1 commit into
developfrom
fix/commit-dist-condition

Conversation

@mikepenz

Copy link
Copy Markdown
Owner

The commit-dist job condition used github.actor to detect Renovate PRs, but github.actor reflects whoever triggered the run — not who opened the PR. When the repo owner manually re-runs CI on a Renovate PR, github.actor becomes mikepenz and the job is incorrectly skipped.

Fix: use github.event.pull_request.user.login instead, which always reflects who opened the PR regardless of who triggered the run.

Copilot AI review requested due to automatic review settings March 27, 2026 19:33
@github-actions

Copy link
Copy Markdown
TestsPassed ✅SkippedFailed
JUnit Test Report67 ran67 passed0 skipped0 failed
TestResult
No test annotations available

@mikepenz mikepenz added the other label Mar 27, 2026
@mikepenz
mikepenz merged commit d7b8cec into develop Mar 27, 2026
12 checks passed
@mikepenz
mikepenz deleted the fix/commit-dist-condition branch March 27, 2026 19:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts automation around Renovate PR handling so the commit-dist job runs under the correct circumstances, and tweaks Renovate vulnerability alert labeling.

Changes:

  • Updates commit-dist job gating logic in CI workflow for Renovate PRs.
  • Adds dependencies label to Renovate vulnerability alert issues.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
renovate.json Expands vulnerability alert labels to include dependencies.
.github/workflows/ci.yml Modifies commit-dist conditional logic intended to detect Renovate PRs and handle re-runs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
github.event.pull_request.head.repo.full_name == github.repository
startsWith(github.head_ref, 'renovate/') &&
github.event.pull_request.head.repo.full_name == github.repository &&
github.actor == github.repository_owner

Copilot AI Mar 27, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new commit-dist condition still relies on github.actor (now comparing it to github.repository_owner). This appears to reintroduce the original problem described in the PR (the trigger actor can change on re-runs) and also prevents commit-dist from running on the initial Renovate PR run (where github.actor is typically renovate[bot]). To match the PR description and make the condition stable across re-runs, key the check off the PR author instead (e.g., github.event.pull_request.user.login) and avoid gating on github.actor for Renovate detection.

Suggested change
github.actor == github.repository_owner
github.event.pull_request.user.login == 'renovate[bot]'

Copilot uses AI. Check for mistakes.
Comment thread renovate.json
"osvVulnerabilityAlerts": true,
"vulnerabilityAlerts": {
"labels": ["security"],
"labels": ["dependencies", "security"],

Copilot AI Mar 27, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change to vulnerabilityAlerts.labels adds the dependencies label, but the PR description focuses only on the commit-dist workflow condition change. If this label change is intended, it should be called out in the PR description (or split into a separate PR) to keep the scope clear.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants