Skip to content

[Bug] CRT shader doesn't work on HTML exports with alone=1 #2229

Closed

Description

@scambier

Version 1.1.2624-dev

When exporting an html with the option alone=1, the CRT shader doesn't work.
It prints these error messages non-stop:

Failed to load vertex shader: [tic80.js:8:23405](http://127.0.0.1:8080/tic80.js)
Error: vertex shader is empty. [tic80.js:8:23405](http://127.0.0.1:8080/tic80.js)
Error: pixel shader is empty.

Activity

  1. nesbox commented on Aug 14, 2023

    @nesbox
    Owner

    can't reproduce on the latest dev

  2. scambier commented on Aug 19, 2023

    @scambier
    Author

    Found the issue: the CRT shader works for Lua carts, but not JS (and maybe others) when using alone=1

    I guess the CRT code is somehow bounded to Lua, and gets stripped with alone=1

    For all examples, I've used the latest stable build (1.1.2729 Pro), and the default language-specific new cart.

  3. reopened this on Aug 20, 2023
  4. self-assigned this
    on Aug 24, 2023
  5. nesbox commented on Aug 24, 2023

    @nesbox
    Owner

    I reproduced it, thanks

  6. added a commit that references this issue on Aug 24, 2023
  7. nesbox commented on Aug 24, 2023

    @nesbox
    Owner

    I moved the shader code from config directly to main.c, this allows us to init CRT effect without Lua.
    fixed here 5b97399

  8. added a commit that references this issue on Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions