Skip to content

Sort input file list - #528

Merged
aquette merged 1 commit into
networkupstools:masterfrom
bmwiedemann:glob
May 15, 2018
Merged

aquette merged 1 commit into
networkupstools:masterfrom
bmwiedemann:glob

Conversation

@bmwiedemann

Copy link
Copy Markdown
Contributor

so that nut builds in a reproducible way
in spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461

See https://reproducible-builds.org/ for why this is good.

so that nut builds in a reproducible way
in spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461

See https://reproducible-builds.org/ for why this is good.
@clepple clepple added the patch label Feb 21, 2018
@clepple clepple self-assigned this Feb 21, 2018
@bmwiedemann

Copy link
Copy Markdown
Contributor Author

Can I do something to help get this merged?

@jimklimov

Copy link
Copy Markdown
Member

Poke more? :)
Looks good to me, though I think the sorting here would be based on LANG or LC_ALL active during a build (not sure if that impacts the ASCII filenames anyhow).

@bmwiedemann

Copy link
Copy Markdown
Contributor Author

I think that is more a concern for the standalone sort(1) program and less so for the builtin perl/python sort functions.

https://stackoverflow.com/questions/8776807/is-pythons-sort-function-the-same-as-linuxs-sort-with-lc-all-c seems to suggest that it is not using locales by default.

@jimklimov

Copy link
Copy Markdown
Member

@clepple : was there a particular reason you self-assigned this PR and it got on hold over time, e.g. do you have something in mind to experiment with / make sure of? Or can it indeed be merged?

@aquette

aquette commented May 15, 2018

Copy link
Copy Markdown
Member

LGTM
as for Charles' self assignment, I probably asked him to take over...

@aquette
aquette merged commit d693c42 into networkupstools:master May 15, 2018
@aquette

aquette commented May 15, 2018

Copy link
Copy Markdown
Member

@bmwiedemann thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants