Repository navigation
New driver: microsol-apc - #994
Conversation
Derived from solis driver, for newer APC Back-UPS BR hardware. Support added for APC Back-UPS BZ1500, BZ2200BI and BZ2200I. Tested on BZ2200BI. Created common file that may be used on solis as well.
|
This pull request introduces 1 alert when merging 69a3c00 into fbe7806 - view on LGTM.com new alerts:
|
Also passed microsol-common.c through indent
Bug identified with data provided on issue networkupstools#697
|
I'll be testing this! 👍👍 |
| #include "microsol-apc.h" | ||
|
|
||
| #define DRIVER_NAME "APC Back-UPS BZ series UPS driver" | ||
| #define DRIVER_VERSION "0.68" |
There was a problem hiding this comment.
Please check if the DRIVER_NAME is right? It seems to mismatch the description in the file heading a bit. Also, for a new driver makes sense to start with new numbering, unless it is very closely related to this version (minus one?) of another driver used as a starting point?
There was a problem hiding this comment.
Just pushed a new commit fixing the DRIVER_NAME. As for the version, does the project have any guidelines for the numbering? If not, I would use version 1.0.
There was a problem hiding this comment.
Good question, I don't remember any such guidance. Looking at existing sources, most drivers have 0.XY numbers with a few claiming non-zero major number and a few having one digit after decimal. I don't think there were particular reasons for any number, other than increasing the value as features/logic were changed or added. Probably the zero reflects a "young" driver that should graduate into higher numbers as many devices are proven to be supported and bugless, but I think this was never automated or pursued manually.
@clepple @aquette : any insights on DRIVER_VERSION assignments?
There was a problem hiding this comment.
Indeed X.YZ. probably around the new-driver doc, or simply inherited from what Russel did setup. Would need official formalization and possible enforcement mister new Leader ;)
|
@rpvelloso : how did the testing go? :) @ygorre: thanks for the contribution! Is this a vendor-backed update (to reflect in docs/acknowledgements.txt)? |
In upsdrv_info, split contributors one per line for better source readability
|
Had not time to test it yet. |
Derived from solis driver supporting newer APC Back-UPS BR hardware.
Support added for APC Back-UPS BZ1500, BZ2200BI and BZ2200I.
Tested on BZ2200BI.
Created common file that may be used on solis as well.