Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Support dotall ('s' flag) in regexp #570

Open

Description

@boingoing
  • Version: All
  • Platform: All
  • Subsystem: All

ChakraCore does not support the 's' regex flag so if Javascript code in node.js uses this flag, we will throw a syntax error. We can work around this by replacing '.' by something like '[\s\S]' and removing the flag but this is a temporary solution at best. When ChakraCore supports the dotall flag, we should remove any of these workarounds. Including this one: 783e99a

Activity

  1. boingoing commented on Jul 11, 2018

    @boingoing
    ContributorAuthor

    ChakraCore is tracking this via chakra-core/ChakraCore#2787

  2. rhuanjl commented on Sep 20, 2018

    @rhuanjl
    Contributor

    dotAll is now in chakracore master chakra-core/ChakraCore#5592 - assumedly need to wait for the next CC release for it to be in a release branch though.

  3. kfarnung commented on Sep 20, 2018

    @kfarnung
    Contributor

    Yup, we'll pick this up in vNext.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions