You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
bug: spreading Headers object has breaking behavior in versions between Node 20.12 and 20.13 #3267
// Comment out this comment and have the latest undici installed just to verify it's still// present in latest Undici, but for the test you can use the global Undici bundled in Node// import { fetch } from "undici";{constbaseHeaders={"x-foo": "bar"};constrequestHeaders=newHeaders({"Content-Type": "application/json"});constheaders={
...baseHeaders,
...requestHeaders,};console.log("Result",headers);awaitfetch("https://google.com",{method: "POST",
headers,});}
Run the code in Node 20.12 and 20.13. 20.12 works fine, while 20.13 panics with TypeError: Could not convert argument of type symbol to string.
Expected Behavior
It to work like it did in 20.12 - afterall I didn't bump any major version, so if this is an intentional breaking change on Undici's side it shouldn't have been included in a minor version of Node.js.
Logs & Screenshots
Environment
Latest MacOS
Node 20.13
Additional context
A separate issue for Node perhaps, but spreading the Headers object probably shouldn't even include the Symbol(headers list) to begin with, this is how it looks in the browser for example:
// Comment out this comment and have the latest undici installed just to verify it's still// present in latest Undici, but for the test you can use the global Undici bundled in Node// import { fetch } from "undici";{constbaseHeaders={"x-foo": "bar"};constrequestHeaders=newHeaders({"Content-Type": "application/json"});constheaders={
...baseHeaders,
...Object.fromEntries(requestHeaders),};console.log("Result",headers);awaitfetch("https://google.com",{method: "POST",
headers,});}
Yes I know I can do that, (and I did work around the issue in pingdotgg/uploadthing#813) - but that's working around the issue that the behavior changed in a minor Node.js release (havent tracked down what exact Undici release the behavior changed in)
@mcollina, yeah, you are right. Headers instance itself won't spread, it will return an empty object. But neither will it throw, so that behavior is unexpected although useful as it lets the user know they aren't doing anything (the error is not hinting at that, though).
Activity
kettanaito commentedon May 16, 2024
Reported tangentially by MSW users as well.
tsctx commentedon May 16, 2024
You are using the spread operator incorrectly.
In
Headersyou need to use it with arrays, not objects.tsctx commentedon May 16, 2024
just use
Object.fromEntries.juliusmarminge commentedon May 16, 2024
Yes I know I can do that, (and I did work around the issue in pingdotgg/uploadthing#813) - but that's working around the issue that the behavior changed in a minor Node.js release (havent tracked down what exact Undici release the behavior changed in)
mcollina commentedon May 16, 2024
From a quick look at the behaviors in browsers, I think that the correct implementation is:
Note that the following does not work in browsers either:
It will result in not having
Content-Typeinheadersobject.Having said that, I think it should not crash but works as expected & similarly to browsers.
@KhafraDev ping
kettanaito commentedon May 16, 2024
@mcollina, yeah, you are right. Headers instance itself won't spread, it will return an empty object. But neither will it throw, so that behavior is unexpected although useful as it lets the user know they aren't doing anything (the error is not hinting at that, though).
juliusmarminge commentedon May 16, 2024
Oh wow I didnt even realize that. Was too focused looking at the Symbols xD
juliusmarminge commentedon May 16, 2024
Checked some other runtimes:
KhafraDev commentedon May 16, 2024
This was caused by fd66cf0 which exposed the issue. Our only choice is to move towards private properties I think.
File-permissionsagreed26 commentedon Oct 20, 2025