Repository navigation
fix: pass dev font server errors to the next middleware - #891
Conversation
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Vite development asset middleware now wraps event creation and Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change forwards development font-server errors to the next middleware; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/assets.tsParsing error: Unexpected token { Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fix/tailwind-v4 #891 +/- ##
===================================================
+ Coverage 70.32% 70.64% +0.32%
===================================================
Files 12 12
Lines 492 494 +2
Branches 125 125
===================================================
+ Hits 346 349 +3
- Misses 116 117 +1
+ Partials 30 28 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Deploying fonts with
|
| Latest commit: |
16f8a2a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://856aab07.fonts-dsw.pages.dev |
| Branch Preview URL: | https://fix-storybook.fonts-dsw.pages.dev |
b3376ad to
16f8a2a
Compare
🔗 Linked issue
📚 Description
the storybook/histoire dev middleware did
res.end(await devEventHandler(evt)), so a 404 from the font handler rejected unhandled.now, we pass it to
next(error).