Skip to content

fix: pass dev font server errors to the next middleware - #891

Merged
danielroe merged 1 commit into
fix/tailwind-v4from
fix/storybook
Aug 23, 2026
Merged

danielroe merged 1 commit into
fix/tailwind-v4from
fix/storybook

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

the storybook/histoire dev middleware did res.end(await devEventHandler(evt)), so a 404 from the font handler rejected unhandled.

now, we pass it to next(error).

@pkg-pr-new

pkg-pr-new Bot commented Aug 23, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/fonts@891

commit: 16f8a2a

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cbe784f8-ba21-4c94-a161-5e598d4d3c7c

📥 Commits

Reviewing files that changed from the base of the PR and between d0b8216 and b3376ad.

📒 Files selected for processing (1)
  • src/assets.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Vite development asset middleware now wraps event creation and devEventHandler execution in try/catch. When an error occurs, the middleware passes it to next(error) instead of leaving the request rejection unhandled.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b3376

This localized change forwards development font-server errors to the next middleware; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: forwarding development font server errors to the next middleware.
Description check ✅ Passed The description explains the unhandled rejected 404 and the change to call next(error), which matches the changeset.
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/storybook

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/assets.ts

Parsing error: Unexpected token {


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Aug 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.64%. Comparing base (50da1a4) to head (16f8a2a).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           fix/tailwind-v4     #891      +/-   ##
===================================================
+ Coverage            70.32%   70.64%   +0.32%     
===================================================
  Files                   12       12              
  Lines                  492      494       +2     
  Branches               125      125              
===================================================
+ Hits                   346      349       +3     
- Misses                 116      117       +1     
+ Partials                30       28       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 23, 2026 •

Copy link
Copy Markdown

Deploying fonts with  Cloudflare Pages  Cloudflare Pages

Latest commit: 16f8a2a
Status: ✅  Deploy successful!
Preview URL: https://856aab07.fonts-dsw.pages.dev
Branch Preview URL: https://fix-storybook.fonts-dsw.pages.dev

View logs

@danielroe
danielroe added this pull request to the merge queue Aug 23, 2026
Merged via the queue into main with commit 39edd49 Aug 23, 2026
12 checks passed
@danielroe
danielroe deleted the fix/storybook branch August 23, 2026 21:17
@github-actions github-actions Bot mentioned this pull request Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants