Repository navigation
fix(local): scan for font files during module setup - #929
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
commit: |
Deploying fonts with
|
| Latest commit: |
0f0b187
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://80f89dd5.fonts-dsw.pages.dev |
| Branch Preview URL: | https://fix-local-provider-lazy-init.fonts-dsw.pages.dev |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe module now creates the local provider during setup when Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to No actionable regression is established in the provider setup or updated font snapshots; the PR appears ready to merge after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #929 +/- ##
==========================================
+ Coverage 71.91% 72.51% +0.60%
==========================================
Files 15 15
Lines 712 713 +1
Branches 189 190 +1
==========================================
+ Hits 512 517 +5
+ Misses 171 165 -6
- Partials 29 31 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🔗 Linked issue
📚 Description
now that we initialise providers lazily in unifont, we accidentally broke the local provider, which then registered nitro hooks too late.