Skip to content

CI: Update to VS 2026 - #13543

Merged
RytoEX merged 2 commits into
obsproject:masterfrom
RytoEX:update-to-vs2026
Jun 12, 2026
Merged

RytoEX merged 2 commits into
obsproject:masterfrom
RytoEX:update-to-vs2026

Conversation

@RytoEX

@RytoEX RytoEX commented Jun 11, 2026

Copy link
Copy Markdown
Member

Description

Important

Because this updates .github/workflows/sign-windows.yaml, the commit hash for consuming that must be updated, which means this requires a merge commit.

Update CI to use VS 2026:

  • Update the CI image to windows-2025-vs2026
  • Update VS generator to 2026
  • Update Windows SDK to 26100

Motivation and Context

After the recent clang-format update in #13402, we discovered that the way we applied braces to only C++ is not supported by clang-format 19 (the version we currently use). It was added in clang-format 20. VS 2026 ships with clang-format 22.

  1. Updating to VS 2026 would give us clang-format 22 by default.
  2. The windows-2025-vs2026 image is now GA.
  3. GitHub is switching windows-2025 and windows-latest to the windows-2025-vs2026 image in June.
  4. While we're not "overdue" to update, now is as good a time as any.

How Has This Been Tested?

Built on my fork's CI.
https://github.com/RytoEX/obs-studio/actions/runs/27319184501

I haven't done runtime tests.

Types of changes

  • CI

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

RytoEX added 2 commits June 10, 2026 22:12
This will also allow us to move to clang-format 22 which ships with
VS 2026.

 * Update the CI image to windows-2025-vs2026
 * Update VS generator to 2026
 * Update Windows SDK to 26100
@RytoEX
RytoEX requested review from PatTheMav and Warchamp7 June 11, 2026 14:43
@RytoEX RytoEX added platform/windows Categorizes issue or PR as affecting Windows specifically area/dependency Issue is in external library or dependency, not OBS itself area/ci labels Jun 11, 2026
Comment thread CMakePresets.json

@Warchamp7 Warchamp7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles and works on my end.

@RytoEX
RytoEX merged commit ef97d2e into obsproject:master Jun 12, 2026
15 checks passed
@RytoEX
RytoEX deleted the update-to-vs2026 branch June 12, 2026 20:57
BlueCheeseburger pushed a commit to BlueCheeseburger/obs-studio that referenced this pull request Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci area/dependency Issue is in external library or dependency, not OBS itself platform/windows Categorizes issue or PR as affecting Windows specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants