Skip to content

Warn when disk space is low before updating in Quattro - #6432

Merged
dhh merged 4 commits into
omacom:quattrofrom
ericvrp:warn-on-low-update-disk-space
Jul 29, 2026
Merged

dhh merged 4 commits into
omacom:quattrofrom
ericvrp:warn-on-low-update-disk-space

Conversation

@ericvrp

@ericvrp ericvrp commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Check available disk space on / once at update startup.
  • Use a 10 GB minimum by default, configurable with OMARCHY_UPDATE_MINIMUM_FREE_DISK_SPACE_GB.
  • Prompt interactive updates before continuing when space is low.
  • Warn and continue without prompting when -y is supplied.
  • Reject invalid threshold values with a clear error.

Motivation

This improves update stability by warning before an update starts when limited disk space could cause it to fail partway through. It is especially useful for older, limited-resource hardware and systems with smaller drives.

The check could be extended to run before each step of the update process. This initial pull request deliberately keeps the implementation basic by checking once at startup, while still preventing a common class of avoidable update failures.

Because the CLI, menu, menubar, and compatibility update entry points converge on omarchy-update, the startup check covers each of them without changes elsewhere.

Testing

  • bash -n bin/omarchy-update
  • git diff --check
  • Forced the low-space path with an artificially high threshold.
  • Verified interactive decline, -y, and invalid override behavior with command stubs so no update ran.
  • ./test/cli currently stops on an unrelated existing missing metadata summary for omarchy-update-system-pkgs-when-conflicted.

Attribution

This is the author's first Omarchy pull request. It was created in OpenCode using the GPT-5.6 Sol LLM.

@ericvrp ericvrp changed the title Warn when disk space is low before updating Warn when disk space is low before updating in Quattro Jul 29, 2026
@ericvrp
ericvrp marked this pull request as ready for review July 29, 2026 19:52
Copilot AI review requested due to automatic review settings July 29, 2026 19:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings July 29, 2026 22:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 29, 2026 22:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 29, 2026 22:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@dhh
dhh merged commit bf4aac9 into omacom:quattro Jul 29, 2026
nick1udwig pushed a commit to nick1udwig/omarchy that referenced this pull request Sep 9, 2026
* Warn when disk space is low before updating

* Simplify update free space warning

* Stop updates without enough free space

* Allow forcing updates with low disk space

---------

Co-authored-by: David Heinemeier Hansson <david@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants