Repository navigation
Fixes #32548: Support BigQuery STRUCT profiling - #32549
Conversation
Pass SQLAlchemy 2's required parent-registration context when flattening nested BigQuery fields. Refs #32548
Code Review ✅ ApprovedFixes BigQuery STRUCT column profiling by passing SQLAlchemy 2's required parent-registration context to the column expansion logic. Includes regression test covering STRUCT profiling and nested path compilation. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
✅ Playwright Results — workflow succeededValidated commit ✅ 109 passed · ❌ 0 failed · 🟡 1 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 1h 24m 31s ⏱️ Max setup 4m 54s · max shard execution 12m 7s · max shard-job elapsed before upload 17m 31s · reporting 4s 🌐 219.42 requests/attempt · 1.78 app boots/UI scenario · 0.00% common-shard skew Optimization targets still in progress:
🟡 1 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
|
🚦 Removed from the merge queue —
|



Describe your changes:
Fixes #32548
I updated BigQuery STRUCT-column expansion to pass SQLAlchemy 2's required parent-registration context and added a regression test because the old SQLAlchemy 1.x call crashes every profiled table containing a STRUCT.
Type of change:
High-level design:
N/A — small change.
Tests:
Use cases covered
Unit tests
ingestion/tests/unit/observability/profiler/sqlalchemy/bigquery/test_bigquery_profiler_sql.pysqlalchemy-bigquery==1.16.0.sqlalchemy-bigquery==1.17.2.Backend integration tests
Ingestion integration tests
Spider2 BigQueryservice on OpenMetadata atlocalhost:8585.metrics: [rowCount]): 92/92 tables profiled, 184 profiler records, 92 REST writes, zero warnings/errors, exit code 0.Playwright (UI) tests
Manual testing performed
make py_format_checkgit diff --check origin/main...HEADUI screen recording / screenshots:
Not applicable.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.