address feedback from #7478 - #7718
Merged
Merged
Conversation
dashpole
requested review from
MrAlias,
XSAM,
dmathieu,
flc1125 and
pellared
as code owners
December 16, 2025 16:48
Contributor
Author
dmathieu
approved these changes
Dec 16, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7718 +/- ##
=====================================
Coverage 86.2% 86.2%
=====================================
Files 302 302
Lines 21991 21991
=====================================
+ Hits 18967 18969 +2
+ Misses 2643 2641 -2
Partials 381 381
🚀 New features to boost your workflow:
|
MrAlias
approved these changes
Dec 16, 2025
Contributor
|
Looks good to merge early given this is a follow-up. |
dashpole
added a commit
to dashpole/opentelemetry-go
that referenced
this pull request
Dec 17, 2025
Addresses open-telemetry#7478 (review), which was left after the PR merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #7478 (review), which was left after the PR merged.