Skip to content

Wire V2 capability discovery through exec-server RPC - #53723

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/726e8f7e8b4d835b877f31d1d8a9f8eea1ad9c8b
Oct 13, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/726e8f7e8b4d835b877f31d1d8a9f8eea1ad9c8b

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Wire V2 capability discovery through exec-server RPC

What changed

  • Register capabilities/discoverV2 for initialized sessions and expose it through ExecServerClient and remote Environment APIs, checking executor support before calling it.
  • Reuse startup discovery locations and retry failed prewarming on demand. Replay discovery once after executor recovery while preserving the request parameters.
  • Track whether all required filesystem watches registered successfully and reload locations and metadata on each request when registration fails.

Testing

Add coverage for RPC metadata refresh, omission of skill instruction bodies, sandbox isolation, startup scan recovery, disconnect replay, and successful or failed watch registration.

## What changed

- Register `capabilities/discoverV2` for initialized sessions and expose it through `ExecServerClient` and remote `Environment` APIs, checking executor support before calling it.
- Reuse startup discovery locations and retry failed prewarming on demand. Replay discovery once after executor recovery while preserving the request parameters.
- Track whether all required filesystem watches registered successfully and reload locations and metadata on each request when registration fails.

## Testing

Add coverage for RPC metadata refresh, omission of skill instruction bodies, sandbox isolation, startup scan recovery, disconnect replay, and successful or failed watch registration.

GitOrigin-RevId: 726e8f7e8b4d835b877f31d1d8a9f8eea1ad9c8b
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/726e8f7e8b4d835b877f31d1d8a9f8eea1ad9c8b branch from 74fcfa1 to 703d253 Compare October 13, 2026 17:22
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-13T17:22:46.820601Z 74fcfa1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot merged commit 703d253 into main Oct 13, 2026
15 of 22 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/726e8f7e8b4d835b877f31d1d8a9f8eea1ad9c8b branch October 13, 2026 17:22
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 13, 2026

This branch was previously deployed

1 inactive deployment
issue-triage — 703d253e Deployed Oct 13, 2026 by anotb via Identify potential duplicates (open issues fallback) #55147
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants