[greg-at-moderne]

What's changed?

Additional guards added in two recipes PrintStackTraceToLogError and CompleteExceptionLogging.

Basically the recipes assumed that calls to .getMessage() or similar methods from Throwable always came qualified, i.e. e.getMessage(). That's not necessarily the case in a Throwable subclass.

What's your motivation?

Otherwise they fail with NPEs like:

java.lang.NullPointerException: Cannot invoke "org.openrewrite.java.tree.J.withPrefix(org.openrewrite.java.tree.Space)" because "parameter" is null
	at org.openrewrite.java.internal.template.Substitutions.substituteTypedPattern(Substitutions.java:157)
	at org.openrewrite.java.internal.template.Substitutions.substitute(Substitutions.java:75)
	at org.openrewrite.java.JavaTemplate.apply(JavaTemplate.java:110)
	at org.openrewrite.java.logging.PrintStackTraceToLogError$1.replaceMethodInvocation(PrintStackTraceToLogError.java:113)
	at org.openrewrite.java.logging.PrintStackTraceToLogError$1.visitMethodInvocation(PrintStackTraceToLogError.java:93)

or

java.lang.NullPointerException
	at java.base/java.util.Objects.requireNonNull(Objects.java:233)
	at java.base/java.util.Optional.of(Optional.java:113)
	at java.base/java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:647)
	at org.openrewrite.java.logging.slf4j.CompleteExceptionLogging$1.visitMethodInvocation(CompleteExceptionLogging.java:143)