Skip to content

Fix LoggersNamedForEnclosingClass crashes and this.class handling in Groovy - #314

Merged
greg-at-moderne merged 1 commit into
mainfrom
greg-loggers-named-for-enclosing-class-groovy
Oct 15, 2026
Merged

greg-at-moderne merged 1 commit into
mainfrom
greg-loggers-named-for-enclosing-class-groovy

Conversation

@greg-at-moderne

Copy link
Copy Markdown
Contributor

What's changed?

Fix LoggersNamedForEnclosingClass crashes and this.class handling for Groovy source code.

What's your motivation?

java.lang.ClassCastException: class org.openrewrite.java.tree.J$Erroneous cannot be cast to class org.openrewrite.java.tree.J$MethodInvocation
  org.openrewrite.java.internal.template.JavaTemplateParser.parseMethodArguments(JavaTemplateParser.java:223)
  org.openrewrite.java.internal.template.JavaTemplateJavaExtension$1.visitMethodInvocation(JavaTemplateJavaExtension.java:516)
  org.openrewrite.java.JavaTemplate.doApply(JavaTemplate.java:133)
  org.openrewrite.java.JavaTemplate.apply(JavaTemplate.java:110)
  org.openrewrite.java.logging.slf4j.LoggersNamedForEnclosingClass$1.replaceMethodArgument(LoggersNamedForEnclosingClass.java:107)
  org.openrewrite.java.logging.slf4j.LoggersNamedForEnclosingClass$1.visitMethodInvocation(LoggersNamedForEnclosingClass.java:93)

observed in production.

@greg-at-moderne greg-at-moderne self-assigned this Oct 15, 2026
@github-project-automation github-project-automation Bot moved this to In Progress in OpenRewrite Oct 15, 2026
@greg-at-moderne
greg-at-moderne marked this pull request as ready for review October 15, 2026 14:28
@greg-at-moderne
greg-at-moderne merged commit 36e739c into main Oct 15, 2026
1 check passed
@greg-at-moderne
greg-at-moderne deleted the greg-loggers-named-for-enclosing-class-groovy branch October 15, 2026 14:28
@github-project-automation github-project-automation Bot moved this from In Progress to Done in OpenRewrite Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant