Repository navigation
AddJaxbRuntime: update JAXB runtime versions held in parent POM and Gradle properties - #1309
Merged
Merged
Conversation
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddJaxbRuntimehands its dependency changes to four other recipes. Each of those needs a scan pass first, but this recipe called them without one, so they always ran with no scan data. As a result, versions held in properties of other files were never updated:com.sun.xml.bind:jaxb-impl:${jaxb.version}), the dependency was renamed toorg.glassfish.jaxb:jaxb-runtime, but the parent property stayed at the old version. The upgrade to 2.3.x was silently skipped.gradle.propertiesor anextvariable, the dependency was renamed but kept the old version, and the variable was never raised to 2.3.x.If the old version was never published under the new coordinates, both cases broke the build.
These recipes now scan along with
AddJaxbRuntime, so property-based versions are upgraded alongside the rename. A side effect is that the rename and upgrade now also apply to Kotlin build scripts (build.gradle.kts).Affects every migration that includes
jaxb-apis.yml: Java 11+, Jakarta EE and Spring Boot.New tests in
AddJaxbRuntimeTestcover the Maven parent-property andgradle.propertiescases.