Repository navigation
Only add jakarta.annotation-api for JSR-250 types, not JSR-305 - #1316
Merged
Merged
Conversation
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddCommonAnnotationsDependenciesaddedjakarta.annotation-api:1.3.xwhenever anything underjavax.annotation..*was used. That also matched JSR-305 types (javax.annotation.Nullable,Nonnull,CheckForNull,javax.annotation.concurrent.*) and the JDK'sjavax.annotation.processing.*. None of those are injakarta.annotation-api, so the added dependency did nothing.onlyIfUsingtakes only one type pattern, so the singleAddDependencyis now one entry per JSR-250 type:javax.annotation.Generated,ManagedBean,PostConstruct,PreDestroy,Priority,Resource,Resourcesjavax.annotation.security.*javax.annotation.sql.*The Jakarta EE 9
AddJakartaAnnotationDependencykeeps its broader pattern. Its tests expectjavax.annotation.Nonnullto migrate tojakarta.annotation, which hasNonnullandNullablesince 2.1.Tests:
@Nullableand@ThreadSafewithjsr305on the pom: the pom is unchanged. This test fails without the fix.@PostConstructand@RolesAllowedused together: exactly one dependency is added.