Repository navigation
Set Java version marker directly in tests using allSources - #1344
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
org.openrewrite.java.Assertionsis now annotated@CheckReturnValue, soFindIgnoredCheckReturnValuefrom rewrite-static-analysis flags everyallSources(source -> version(source, N)): theConsumerlambda discards the returnedSourceSpec. The calls work anyway, becauseversionmutates the spec in place, but the warnings are noise. This switches the 10 occurrences across 8 test classes tos -> s.markers(javaVersion(N))and drops theversionimport where it is no longer used.Same change as openrewrite/rewrite-static-analysis#1114 for
InstanceOfPatternMatchTest.Verified by running the 8 affected test classes with
./gradlew test --tests ...: 166 tests, all passing.