Repository navigation
C1: NoValueOfOnStringType keeps one String.valueOf when both concatenation operands are valueOf calls - #1127
Merged
Merged
Conversation
…atenation operands are `valueOf` calls
15 of 41 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes C1 of #1116:
NoValueOfOnStringType(inCommonStaticAnalysis) turnedString.valueOf(a) + String.valueOf(b)withintoperands intoa + b, so string concatenation silently became integer addition.Each operand was checked against the original binary, where the other operand was still a
String-typedvalueOfcall, so both calls were removed. The left operand now keeps its call when the right operand is aString.valueOf(primitive)that will lose its own, which givesString.valueOf(a) + b. When the right argument is aString, both calls are still removed, because the result stays a concatenation.Verified with
./gradlew test --tests "*NoValueOfOnStringType*" --tests "*CommonStaticAnalysis*": the newkeepOneValueOfWhenBothOperandsAreValueOftest fails onmain(it produceda + banda + b + a) and passes here.