Repository navigation
Leave a Stack as it is when rewrite-analysis cannot follow where it flows, as its last release cannot through an anonymous class - #1151
Merged
Conversation
… flows, as its last release cannot through an anonymous class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CGP's release train, rewrite-static-analysis 2.46.0's release build failed
ReplaceStackWithDequeTest.doNotFailOnAnonymousClassWithMultipleReturningMethodstwice. The cause was inside rewrite-analysis, atForwardFlow$Analysis.visitNewClass(ForwardFlow.java:381).A build of
mainresolves rewrite-analysis's2.40.0-SNAPSHOT, which has the fix (rewrite-analysis cb0fbd69b4, "Print and visit trees under their parent cursor"). A release resolves its last release, 2.39.0, which doesn't. openrewrite/rewrite-analysis was archived on 2026-10-17 without releasing that fix. So a release of this recipe would have thrown on that code for anyone using it, which is what the regression test says it must not do.When rewrite-analysis can't follow where the
Stackflows, the recipe now leaves it as it is: the same outcome the test expects once the analysis works ("dataflow correctly detects thatresultis returned, so the Stack is not rewritten"). With rewrite-analysis forced to 2.39.0, the test fails onmainand passes with this change.The longer-term choice is still open: release rewrite-analysis's last commits as 2.40.0, or move off the archived module.