Repository navigation
Keep the method type in sync with the return type in ConvertToRawType - #1202
Merged
Merged
Conversation
ConvertToRawType made a method's return type expression raw but left its JavaType.Method returning the parameterized type. The method type now gets the same raw return type, and the method name holds the same JavaType.Method instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With openrewrite/rewrite#9284,
RewriteTest's type validation compares a method declaration's return type expression with the return type of itsJavaType.Method.ConvertToRawTypeTest.methodReturnTypefails under it:ConvertToRawTypechanges the return type expression from the parameterized container type to its raw type, but the method type still returns the parameterized container type, so method matchers and later recipes see the old signature. The recipe now gives the method type the new return type, and gives the method name the sameJavaType.Methodinstance, which type validation also requires.The test fails with #9284's rewrite-java and passes with this change. The suite stays green against the current snapshot.