Improved pull request "Files Changed" experience feedback #163932
Replies: 3344 comments 1394 replies
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
|
It doesn't always seem to remember if hide whitespace was turned on. |
|
Apologies if it's repeated, but links direct to review comments are not properly displaying the comment, they just lead to the base PR page |
|
|
In PR File change tab, I would like to request for showing "Total Opening PR comments" that needs to be resolved |
|
As a screenreader user, I am still unable to fully adopt this new "Files changed" experience. But I lose some time and even have difficulties reading existing comments while reviewing the code or other comments and understanding the state of the PR:
And overall, providing feedback in this unique discussion with more than 1000 replies just makes tracking of all improvements impossible!!! Each one provide their comment and these comments seem to go into a bottomless well. Then one day, we notice GUI changes and we do not know if these changes are due to modifications made by the GitHub dev team or to a transient bug. |
|
Can you make it so that generated files appear as "Viewed" by default? Marking files as generated hides the diff but they still appear and we still need to manually mark them as viewed. This makes the "generated file" marker quite useless, in the end the workflow is the same, it just takes less space on the screen. |
|
🤔 I don't know if this is a feature or bug, but if I'm in "Files changed" view and I pushed new commit, it doesn't automatically reflect, nor does it show "Refresh" button like before. Is this expected? 🫤 @Akash1134 |
|
Hi. Previously, when I scrolled down (for example in the "Files changed" section), the top menu with the |
|
I've been having trouble scrolling back up after refreshing a PR with a 15ish unviewed files in a 30-ish file PR. I can bypass this by dragging the scroll bar to the top of the PR, and then scrolling down from the top. |
|
I found two navigation issues:
|
|
Hi @Akash1134 and team, Thanks for the new "Files changed" experience. Draft comments that survive a refresh, the resizable file tree, and commenting on any line are all big improvements. Here is some feedback based on the limitations and updates listed in the post. What works well
Enhancements that would have the most impact for me
Bugs / rough edges Thanks again for the work on this, and for reading all the feedback! |
|
Tip What’s Working Great
Next Priority Request: Regards, |
|
For anyone here who reviews large PRs: I built PR Sift, a free Chrome extension for the Files changed page (disclosure: I'm the author).
It's free, also for commercial use, with no account and no analytics, and it works on private repos. The code is public on GitHub. If something is missing for your workflow, tell me here or open an issue. |
About the new experienceThis updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog. Tip If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu. ✨ What's newIf you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ UpdatesSee what's been fixed and improved since the launch of the public preview:
🟡 LimitationsAs of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment! |






















Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
✨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ Updates
See what's been fixed and improved since the launch of the public preview:
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
All reactions