Skip to content

✨ Add intoto results format - #1702

Merged
justaugustus merged 2 commits into
ossf:mainfrom
puerco:intoto-formatter
Oct 11, 2026
Merged

justaugustus merged 2 commits into
ossf:mainfrom
puerco:intoto-formatter

Conversation

@puerco

@puerco puerco commented Sep 8, 2026 •

Copy link
Copy Markdown
Member

This PR adds support for the missing "intoto" value in the results_format input. The formatter delegates to scorecard's Result.AsInToto, wrapping the JSON results in an in-toto attestation statement just as the scorecard binary does with --format=intoto.

It also updates the readme with the value and adds it in action.yaml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Update the action description and image tag before approval.

2 open findings
What changed in this PR

Adds intoto result formatting through Scorecard’s attestation API and documents the new option.

Changes:

  • Adds in-toto formatting and test coverage.
  • Updates README documentation.
  • Advertises intoto in action metadata.
File Summary
README.md Documents the intoto format.
internal/​scorecard/​format.go Adds in-toto output handling.
internal/​scorecard/​format_test.go Tests in-toto formatting.
action.yaml Advertises intoto; the description should list all supported formats (nit, 2 votes), and the pinned image must include this formatter before advertising it (moderate, 2 votes).

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread action.yaml
Comment thread action.yaml
@justaugustus justaugustus mentioned this pull request Oct 11, 2026
13 tasks
@justaugustus justaugustus added this to the v2.5.0 milestone Oct 11, 2026
puerco and others added 2 commits October 11, 2026 19:21
This commit adds support for the missing "intoto" value in the
results_format input. The formatter delegates to scorecard's
Result.AsInToto, wrapping the JSON results in an in-toto
attestation statement just as the scorecard binary does with
--format=intoto.

It also updates the readme with the value and adds it in action.yaml

Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
Scorecard v5.6.0 validates in-toto statements before writing them, and
the subject digest is the scanned commit, so the test fixture needs a
commit SHA; without one, the intoto case fails against the Scorecard
version on main. Also gofmt the test table, and list all three output
formats in the action description.

Assisted-by: LLM
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
justaugustus enabled auto-merge (squash) October 11, 2026 23:31

@justaugustus justaugustus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @puerco!

@justaugustus
justaugustus merged commit bedb16e into ossf:main Oct 11, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants