Skip to content

Fix errNotImplemented reference - #1835

Merged
kakkoyun merged 1 commit into
mainfrom
arve/fix-not-implemented
Jul 14, 2025
Merged

kakkoyun merged 1 commit into
mainfrom
arve/fix-not-implemented

Conversation

@aknuds1

@aknuds1 aknuds1 commented Jul 14, 2025 •

Copy link
Copy Markdown
Contributor

Replace notImplementedErr reference with errNotImplemented in prometheus/process_collector_mem_nocgo_darwin.go, since the former doesn't exist any longer. This fixes compilation on Mac.

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes a reference to the correct errNotImplemented variable in the Darwin non-cgo memory collector stub.

  • Replace the undefined notImplementedErr with the existing errNotImplemented in getMemory.
  • Ensures the stub compiles against the shared error constant.
Comments suppressed due to low confidence (1)

prometheus/process_collector_mem_nocgo_darwin.go:19

  • Consider adding a unit test to verify that getMemory on Darwin without cgo returns errNotImplemented as expected, ensuring this stub behavior is covered.
	return nil, errNotImplemented

@kakkoyun kakkoyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick action.

@kakkoyun
kakkoyun merged commit c774311 into main Jul 14, 2025
@kakkoyun
kakkoyun deleted the arve/fix-not-implemented branch July 14, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants