Repository navigation
Fix CI bug - #1892
Merged
Merged
Fix CI bug#1892
Conversation
pipiland2612
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
October 9, 2025 07:37
Member
|
Do we know why this happened? We have a routine that generates those metrics. Why we suddenly missed one metric and literally in 1.24 as well? |
Contributor
Author
|
Hmm, let me take a closer look why it is the case here. |
kakkoyun
approved these changes
Oct 10, 2025
saswatamcode
approved these changes
Oct 11, 2025
saswatamcode
left a comment
saswatamcode
left a comment
Member
There was a problem hiding this comment.
LGTM! But we probably need to look at how we missed this
Member
|
ping (: |
Member
|
Also can you provide more meaningful PR title (and commit msg) |
Member
|
Ok digged deeper. The reason is that Go team added this metric in minor version of 1.25.2 and 1.24.8. Fair (: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issues is #1891 (comment) and the PR related to this bugs #1864