Review regex declarations in innodb and global variables collectors - #941
Merged
Merged
Conversation
cristiangreco
force-pushed
the
cristian/fix-regex-vars
branch
from
March 28, 2025 14:30
c2d2222 to
435a092
Compare
SuperQ
reviewed
Jun 26, 2025
SuperQ
approved these changes
Jun 26, 2025
SuperQ
left a comment
SuperQ
left a comment
Member
There was a problem hiding this comment.
Nit about naming, otherwise LGTM
Move regex vars to package level to avoid re-compilation on each scrape. Signed-off-by: Cristian Greco <cristian@regolo.cc>
Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Cristian Greco <cristian@regolo.cc>
Signed-off-by: Cristian Greco <cristian@regolo.cc>
cristiangreco
force-pushed
the
cristian/fix-regex-vars
branch
from
June 26, 2025 16:36
9438693 to
3a7fcf4
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move regex vars to package level to avoid re-compilation on each scrape.