Repository navigation
Provide the available definitions when applying discriminated unions - #11670
Merged
Merged
Conversation
It seems that we forgot to do so, and as almost all discriminated unions involves referenceable schemas (such as models, typed dicts, etc), the deferred metadata key was almost always set. This fixes some issues in the schema cleaning process, although it is still theoretically unsound (see the added tests).
Viicos
added
relnotes-fix
Viicos
marked this pull request as ready for review
April 1, 2025 17:22
Deploying pydantic-docs with
|
| Latest commit: |
3fe195a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eaedca80.pydantic-docs.pages.dev |
| Branch Preview URL: | https://discriminator-defs.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #11670 will not alter performanceComparing Summary
|
Contributor
Coverage report
This PR does not seem to contain any modification to coverable code. |
davidhewitt
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that we forgot to do so, and as almost all discriminated unions involves referenceable schemas (such as models, typed dicts, etc), the deferred metadata key was almost always set.
This fixes some issues in the schema cleaning process, although it is still theoretically unsound (see the added tests).
Fixes #11661.
Change Summary
Related issue number
Checklist