Skip to content

Make Secret covariant - #12008

Merged
Viicos merged 2 commits into
pydantic:mainfrom
bluenote10:make_secret_covariant
Jul 1, 2025
Merged

Make Secret covariant#12008
Viicos merged 2 commits into
pydantic:mainfrom
bluenote10:make_secret_covariant

Conversation

@bluenote10

@bluenote10 bluenote10 commented Jun 23, 2025 •
edited by pydantic-hooky Bot
Loading

Copy link
Copy Markdown
Contributor

Change Summary

This PR make Secret covariant.

Related issue number

Closes #12007

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @DouweM

@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Jun 23, 2025
@codspeed

codspeed Bot commented Jun 23, 2025 •
edited
Loading

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #12008 will not alter performance

Comparing bluenote10:make_secret_covariant (e2d0726) with main (c6d9446)

Summary

✅ 46 untouched benchmarks

@bluenote10
bluenote10 force-pushed the make_secret_covariant branch from a275113 to 44ec597 Compare July 1, 2025 07:40
@github-actions

github-actions Bot commented Jul 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@bluenote10

bluenote10 commented Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

please review

@DouweM

DouweM commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

@Viicos Seems reasonable to me.

@DouweM DouweM assigned Viicos and unassigned DouweM Jul 1, 2025
@Viicos

Viicos commented Jul 1, 2025

Copy link
Copy Markdown
Member

Yes makes sense, thanks @bluenote10, this will be released in the next version (2.12).

@Viicos Viicos added relnotes-change Used for changes to existing functionality which don't have a better categorization. and removed ready for review relnotes-fix Used for bugfixes. labels Jul 1, 2025
@Viicos Viicos changed the title make Secret covariant Make Secret covariant Jul 1, 2025
Viicos
Viicos reviewed Jul 1, 2025
View reviewed changes
Comment thread pydantic/types.py
@Viicos
Viicos enabled auto-merge (squash) July 1, 2025 14:29
@Viicos
Viicos merged commit 568509c into pydantic:main Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Viicos Viicos Viicos approved these changes

Assignees

@Viicos Viicos

Labels

relnotes-change Used for changes to existing functionality which don't have a better categorization.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Secret is unnecessarily invariant, can be made covariant

3 participants

@bluenote10 @DouweM @Viicos