Skip to content

Handle AttributeError subclasses with from_attributes - #13096

Merged
Viicos merged 1 commit into
mainfrom
vp/from-attributes-attributeerror-sub
Apr 20, 2026
Merged

Viicos merged 1 commit into
mainfrom
vp/from-attributes-attributeerror-sub

Conversation

@Viicos

@Viicos Viicos commented Apr 20, 2026

Copy link
Copy Markdown
Member

Change Summary

Fixes #13092

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos added relnotes-fix Used for bugfixes. backport-2.13 Needs backport to 2.13 labels Apr 20, 2026
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: d80a022
Status: ✅  Deploy successful!
Preview URL: https://57a888b2.pydantic-docs.pages.dev
Branch Preview URL: https://vp-from-attributes-attribute.pydantic-docs.pages.dev

View logs

@codspeed

codspeed Bot commented Apr 20, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 6.66%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 214 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_field_function_validator 343.3 µs 321.8 µs +6.66%

Comparing vp/from-attributes-attributeerror-sub (d80a022) with main (a6bf50b)

Open in CodSpeed

@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

alokshukla631

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-2.13 Needs backport to 2.13 relnotes-fix Used for bugfixes.

Projects

None yet

3 participants