[Czaki]

Change Summary

Finally, the last of my dependency reached pydantic 2 compatibility, so I could start migrating my package. I meet an error that requires using a debugger to understand where is a problem as I cannot find which class is responsible for the problem. In this PR I add information about class that have __modify_schema__ and do not have __get_pydantic_json_schema__

Related issue number

Checklist

• The pull request title is a good summary of the changes - it will be used in the changelog
• Unit tests for the changes exist
• Tests pass on CI
• Documentation reflects the changes where applicable
• My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

[sydney-runkle]

@Czaki,

Looks great! Could you please add a test?

[codspeed]

CodSpeed Performance Report

Merging #8917 will not alter performance

_{Comparing Czaki:modify_schema_error (c880b1f) with main (bbf0724)}

Summary

✅ 10 untouched benchmarks

[sydney-runkle]

Left a few quick notes. Looks good, assuming you fix the linting errors as well. Thanks a bunch!

[sydney-runkle]

@Czaki,

You should be able to run make and use pre-commit logic to help you with the linting errors 👍

[Czaki]

I think that I have done it.
I do not know why your pre-commit configuration do not fix formatting and does not print what needs to be fixed.

[sydney-runkle]

@Czaki,

Looks like you fixed the linting, but your test is failing

[Czaki]

Looks like you fixed the linting, but your test is failing

I see, but your workflow is totally different from this one that I’m familiar with, and it takes me longer time to identify how to test things locally.

[sydney-runkle]

Nice work! Thanks!!