Repository navigation
Quad corner editing is lost when rotating the device #195
Description
How to reproduce
- If enabled, remove the rotation lock from your device settings
- In FairScan, capture an image and then open the CropScreen for manual quad editing
- drag one or more corners
- then change the device orientation (from portrait to landscape or vice-versa)
Current behavior
- The crop screen will rotate and the corners are back at their original place
Expected behavior
- The crop screen rotates and the corners stay where they have been manually moved to in the underlying image.
Impact
Let me know if that bug seems worthy of fixing and if yes, whether I shall fix it or you want to do it.
Personally, loosing my (maybe carefully arranged) editing feels frustrating, so I'd rather want it to survive a phone rotation
Activity
PhilLab commentedon Jun 7, 2026
Loosely related: There is currently another way of loosing your careful editing which might surprise some users: on the crop screen, clicking the visual back button (or the device back button) leaves the screen without confirmation. Yes, there is a big "Confirm" button at the bottom, but especially first-time users might not yet know whether this app is one of those who persists every edit or whether it isn't.
@pynicolas Let me know if that shall also be addressed in the same PR, or whether you don't agree.
pynicolas commentedon Jun 7, 2026
@PhilLab Thanks for opening this issue.
I agree that the current state should not be lost when rotating the device. I don't think that there's any hurry do fix that though.
Feel free to open a PR if you want to do it, otherwise I'll do it.
And I don't want to ask for a confirmation when using a back button. I believe the "Apply" button makes the behavior clear enough. If someone makes a mistake and "loses" the current state, it should take only a few seconds to adjust the corners again. If it takes longer, that's what should be fixed in the app.
pynicolas commentedon Jun 26, 2026
Fixed in #208