Repository navigation
Add the ability to set 'inherit' at all levels of the options cascade - #2928
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019fefe0-6bbb-736e-b01c-d7f15d2db320 Co-authored-by: Joe Rickerby <joe@nordprojects.co>
|
This should be ready for review now! |
|
Here's a Claude review. 🤖 AI text below 🤖 Review of PR #2928 is done — 10 findings reported above, ranked by severity. Eight are confirmed with executed reproductions; two (the schema/runtime divergence and the The broad themes:
The reviewer also verified the checked-in schema matches |
|
I've fixed the lazy parsing, added runtime validation, improved the static schema validation rules, and fixed the sentinel issue. ready for another review! |
|
review here would be good if any maintainers have time! it's not as bad as the line diff makes out - only 250 lines of the changes are code, the rest are schema, docs and tests. see cibuildwheel/options.py for the meat of it. |
|
Ran Claude Opus 5.5 on it, found a very minor issue (below). I also looked at potential simplifications, I'll see if I can get these posted as suggestions (I haven't tried posting local changes this way before, so interested to see how it goes). 🤖 AI text below 🤖 The code review of the Finding (low), Fix: Check whether the option supports inheritance before the empty-value early return, so the error does not depend on the data. Scope: The review compared the branch against
The review also confirmed two other changes:
|
henryiii
left a comment
There was a problem hiding this comment.
🤖 AI text below 🤖
Some simplifications, mostly with match. The unit tests and prek pass with all of them applied.
henryiii
left a comment
There was a problem hiding this comment.
See review comments, but otherwise looks good. Address what you want then it's ready, IMO.
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
|
thanks for the reviews @henryiii ! |
Adds the ability for options set in
[tool.cibuildwheel][tool.cibuildwheel.platform]to inherit the values previously set.
Previously one could only inherit in an 'overrides' config.
I always wanted this to be possible for env vars, but I also realised that when we were doing audit-command, it would be useful for projects to be able to extend the default audit (e.g. add
twine checkto the existing abi3audit command). So I think it makes sense to allow this at every user-configurable level.Docs + tests still to come.