Skip to content

Revert "Allow CuPy 11" - #362

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:branch-22.08from
galipremsagar:revert-357-allow_cupy_11
Aug 1, 2022
Merged

rapids-bot[bot] merged 1 commit into
rapidsai:branch-22.08from
galipremsagar:revert-357-allow_cupy_11

Conversation

@galipremsagar

Copy link
Copy Markdown
Contributor

Reverts #357

@galipremsagar
galipremsagar requested a review from a team as a code owner August 1, 2022 14:19
@galipremsagar

Copy link
Copy Markdown
Contributor Author

xref: NVIDIA/cudf#11409

@quasiben

quasiben commented Aug 1, 2022

Copy link
Copy Markdown
Member

I think cuCIM wants to use CuPy 11 even though RAPIDS need to exclude it for now. This has happened in the past where cuCIM needs to specifically add CuPy 11 to the CI infra to properly test

@ajschmidt8

Copy link
Copy Markdown
Member

I think cuCIM wants to use CuPy 11 even though RAPIDS need to exclude it for now. This has happened in the past where cuCIM needs to specifically add CuPy 11 to the CI infra to properly test

@quasiben, will cucim be using CuPy features that are exclusively in CuPy 11? If so, I think this will cause issues with the rapids package on Anaconda (src) if cucim needs CuPy 11, but the rest of RAPIDS can only use CuPy 10.

@ajschmidt8 ajschmidt8 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 1, 2022
@jakirkham jakirkham added this to the v22.08.00 milestone Aug 1, 2022
@jakirkham

Copy link
Copy Markdown
Member

Discussed with @grlee77, we are going to bump the feature that needed CuPy 11 to 22.10. So sticking to CuPy 10 for 22.08 should be ok for us

@jakirkham

Copy link
Copy Markdown
Member

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit 6f22f2e into rapidsai:branch-22.08 Aug 1, 2022
@jakirkham

Copy link
Copy Markdown
Member

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants